Skip to content

added ALTREP to _selfrefok#4756

Merged
mattdowle merged 1 commit intomasterfrom
altrep_mutate
Oct 13, 2020
Merged

added ALTREP to _selfrefok#4756
mattdowle merged 1 commit intomasterfrom
altrep_mutate

Conversation

@mattdowle
Copy link
Copy Markdown
Member

Closes #4734

Not adding a test as the MRE requires dplyr. Adding dplyr as a Suggest would be too heavy a dependency chain. In this case, the fix is clear and straightforward. The nature of the fix in this case means we're ok without a test. I did try and trace through what's happening in dplyr::mutate, and it's maybe something to do with names going through as_utf8_character. When I saw lines like cols <- vec_recycle_common(!!!cols, .size = nrow(data)) with the three !!!, though, I'm lost.

I tested locally and it works now. Let's see if anything else comes up after this fix.

@mattdowle mattdowle added this to the 1.13.1 milestone Oct 13, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2020

Codecov Report

Merging #4756 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4756   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          73       73           
  Lines       14539    14539           
=======================================
  Hits        14458    14458           
  Misses         81       81           
Impacted Files Coverage Δ
src/assign.c 99.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3816230...8a9b4c7. Read the comment docs.

@mattdowle mattdowle merged commit fbaa985 into master Oct 13, 2020
@mattdowle mattdowle deleted the altrep_mutate branch October 13, 2020 05:54
hongyuanjia pushed a commit to hongyuanjia/data.table that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ALTREP bug after adding >=64th column

1 participant