Conversation
Codecov Report
@@ Coverage Diff @@
## master #4756 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 73 73
Lines 14539 14539
=======================================
Hits 14458 14458
Misses 81 81
Continue to review full report at Codecov.
|
hongyuanjia
pushed a commit
to hongyuanjia/data.table
that referenced
this pull request
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4734
Not adding a test as the MRE requires
dplyr. Addingdplyras a Suggest would be too heavy a dependency chain. In this case, the fix is clear and straightforward. The nature of the fix in this case means we're ok without a test. I did try and trace through what's happening indplyr::mutate, and it's maybe something to do with names going throughas_utf8_character. When I saw lines likecols <- vec_recycle_common(!!!cols, .size = nrow(data))with the three!!!, though, I'm lost.I tested locally and it works now. Let's see if anything else comes up after this fix.