Skip to content

add check for trunc.cols #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdowle merged 9 commits into from
Apr 15, 2021
Merged

add check for trunc.cols #4766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
33fe16e
add check for trunc.cols
Oct 18, 2020
82c8ae6
tweak grammar
MichaelChirico Oct 19, 2020
34aded2
added check for NA
Oct 20, 2020
85bd552
typo
Oct 20, 2020
a24346e
add three small tests for trunc.cols check
Oct 20, 2020
e89b1dd
update check
Oct 20, 2020
91bee93
add check for length != 1 trunc.cols
Oct 20, 2020
f137846
Merge branch 'master' into print-check-trunc.cols
mattdowle Apr 15, 2021
8f366a9
1 => 1L
mattdowle Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/print.data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ print.data.table = function(x, topn=getOption("datatable.print.topn"),
# trunc.cols - should only the columns be printed that can fit in the console? (FALSE)
if (!col.names %chin% c("auto", "top", "none"))
stop("Valid options for col.names are 'auto', 'top', and 'none'")
if (length(trunc.cols) != 1L || !is.logical(trunc.cols) || is.na(trunc.cols))
stop("Valid options for trunc.cols are TRUE and FALSE")
if (col.names == "none" && class)
warning("Column classes will be suppressed when col.names is 'none'")
if (!shouldPrint(x)) {
Expand Down
7 changes: 7 additions & 0 deletions inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17319,3 +17319,10 @@ if (identical(text, enc2native(text))) { # ensure native encoding can represent
}
test(2167.3, fwrite(dt, csvfile, encoding="nativ"), error="Argument 'encoding' must be")
unlink(csvfile)

# check valid trunc.cols=, #4766
DT = data.table(x = rnorm(10))
test(2168.01, print(DT, trunc.cols = 5L), error=c("Valid options for trunc.cols are TRUE and FALSE"))
test(2168.02, print(DT, trunc.cols = NA), error=c("Valid options for trunc.cols are TRUE and FALSE"))
test(2168.03, print(DT, trunc.cols = "thing"), error=c("Valid options for trunc.cols are TRUE and FALSE"))
test(2168.04, print(DT, trunc.cols = c(TRUE, FALSE)), error=c("Valid options for trunc.cols are TRUE and FALSE"))