Skip to content

rbind() now works with DTs with zero-length ordered factors#4803

Merged
mattdowle merged 2 commits intomasterfrom
shrektan/fix4795
Apr 29, 2021
Merged

rbind() now works with DTs with zero-length ordered factors#4803
mattdowle merged 2 commits intomasterfrom
shrektan/fix4795

Conversation

@shrektan
Copy link
Copy Markdown
Member

@shrektan shrektan commented Nov 7, 2020

Closes #4795
Closes #4823

@shrektan shrektan added this to the 1.13.5 milestone Nov 7, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 7, 2020

Codecov Report

Merging #4803 (142f8bb) into master (be1c987) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4803   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          73       73           
  Lines       14448    14448           
=======================================
  Hits        14365    14365           
  Misses         83       83           
Impacted Files Coverage Δ
src/rbindlist.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1c987...142f8bb. Read the comment docs.

@mattdowle mattdowle merged commit 6b38f61 into master Apr 29, 2021
@mattdowle mattdowle deleted the shrektan/fix4795 branch April 29, 2021 05:49
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbindlist Internal error: savetl_init checks failed rbind empty ordered factor triggers savetl_init errors

3 participants