Skip to content

fsort segfault with clang-11 openmp#4808

Merged
mattdowle merged 10 commits intomasterfrom
fsort_segfault
Nov 13, 2020
Merged

fsort segfault with clang-11 openmp#4808
mattdowle merged 10 commits intomasterfrom
fsort_segfault

Conversation

@mattdowle
Copy link
Copy Markdown
Member

@mattdowle mattdowle commented Nov 13, 2020

Closes #4786

Supports OpenMP<4.5 by attempting regular dynamic schedule, checking if it is monotonic (probably is), and failing gracefully if not.
See comments in code.
By changing the #define in myomp.h to drop the monotonic: modifier (i.e. to be wrong), I confirmed the new check and error message works.

@mattdowle mattdowle added this to the 1.13.3 milestone Nov 13, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2020

Codecov Report

Merging #4808 (16622da) into master (70b6b13) will increase coverage by 0.00%.
The diff coverage is 98.41%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4808   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14557    14563    +6     
=======================================
+ Hits        14481    14487    +6     
  Misses         76       76           
Impacted Files Coverage Δ
src/init.c 100.00% <ø> (ø)
src/fsort.c 95.88% <98.38%> (+0.12%) ⬆️
src/openmp-utils.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b6b13...16622da. Read the comment docs.

@mattdowle
Copy link
Copy Markdown
Member Author

diff coverage not 100% due to minor changes (e.g. j++ to ++j) on already uncovered lines. Need to revisit all uncovered lines anyway so not holding up this PR due to that.

@mattdowle mattdowle merged commit 70a598d into master Nov 13, 2020
@mattdowle mattdowle deleted the fsort_segfault branch November 13, 2020 06:09
mattdowle added a commit that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compilation with clang11 causes fsort to crash

1 participant