Skip to content

runlock doesnt try to unlock functions#4815

Merged
mattdowle merged 2 commits intomasterfrom
runlock-function
Dec 1, 2020
Merged

runlock doesnt try to unlock functions#4815
mattdowle merged 2 commits intomasterfrom
runlock-function

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #4814

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2020

Codecov Report

Merging #4815 (edd7370) into master (8480b6a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4815   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          73       73           
  Lines       14565    14565           
=======================================
  Hits        14489    14489           
  Misses         76       76           
Impacted Files Coverage Δ
R/data.table.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480b6a...4dfe88b. Read the comment docs.

@jangorecki
Copy link
Copy Markdown
Member

LGTM

@mattdowle
Copy link
Copy Markdown
Member

Travis CI is stuck in queued status again. Proceeding without. GLCI will check after merge and covers it anyway.

@mattdowle mattdowle merged commit 15e6436 into master Dec 1, 2020
@mattdowle mattdowle deleted the runlock-function branch December 1, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aggregation fails for list columns with closures that don't have class "function"

3 participants