Fix segfaults when assigning all-NA-vector to factor column#4829
Merged
Fix segfaults when assigning all-NA-vector to factor column#4829
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4829 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 73 73
Lines 14465 14465
=======================================
Hits 14382 14382
Misses 83 83
Continue to review full report at Codecov.
|
mattdowle
approved these changes
May 7, 2021
Member
mattdowle
left a comment
There was a problem hiding this comment.
Great fix! Thanks for chasing it down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4824
Before the PR,
print(dt)leads to an error thatError in as.character.factor(x) : malformed factor. By inspecting the value ofdt$FACTOR, you should find that some of the values are garbaged.This PR fixes the issue.