Conversation
Fix buffer overrun warning.
Codecov Report
@@ Coverage Diff @@
## master #4896 +/- ##
==========================================
- Coverage 99.46% 99.46% -0.01%
==========================================
Files 73 73
Lines 14414 14413 -1
==========================================
- Hits 14337 14336 -1
Misses 77 77
Continue to review full report at Codecov.
|
|
@MichaelChirico how do you guys prefer to work? Shall I submit this PR (and another one coming) from a clean branch, without the previous PR, and assuming you accept - you'll merge the tests and NEWS? |
|
Thanks for another PR! Unless the fix here depends on the one in #4893 I would try and keep the branches as pristine as possible -- this allows more flexibility on the order when the two are merged. For example, there might be changes requested to one but not the other, so even if they are reviewed by Matt in quick succession, one might still end up merging sooner. Put another way, ideally each should be ready to merge independently of the other; if one is in fact a dependency of the other, mark the "downstream" one as WIP and make note of the dependency in the PR description. Don't worry about the numbering in the NEWS, Matt will handle that in the final merge to master. |
@MichaelChirico Thanks! I'll delete this PR and submit a clean replacement soon. |
Closes #4784
Small fix. Essentially just a change in order of two operations.