Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5105 +/- ##
==========================================
- Coverage 99.54% 99.54% -0.01%
==========================================
Files 76 76
Lines 14691 14592 -99
==========================================
- Hits 14624 14525 -99
Misses 67 67
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gmaxintogminbecominggminmaxto avoid the duplicated logic so that future maintenance can be in one placena.rm=FALSE, once anNAhas occurred in a group, there is no need to fetch the value of the remaining values in that groupInf, it was just to be consistent with baseThere is some overlap with @MichaelChirico's #4445 here which fixes
integer64support ingmin/gmax. I'll merge that next which should be easier as it's now in onegminmax.Merging so the NEWS item is published in dev and folk can test dev. Everything in dev is still open for discussion and reconsideration before release.