add incomparables arg to merge.data.table and warn about passing arguments to ...#5233
Merged
add incomparables arg to merge.data.table and warn about passing arguments to ...#5233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5233 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 77 77
Lines 14631 14643 +12
=======================================
+ Hits 14559 14571 +12
Misses 72 72
Continue to review full report at Codecov.
|
This was referenced Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2587
Closes #2593
Implements option 1 and 2 from here
Does not add an additional argument to
[.data.table(there are already 17 of them)