Conversation
Codecov Report
@@ Coverage Diff @@
## master #5235 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 77 77
Lines 14655 14660 +5
=======================================
+ Hits 14583 14588 +5
Misses 72 72
Continue to review full report at Codecov.
|
Member
MichaelChirico
left a comment
There was a problem hiding this comment.
I think users will expect by=.(.I) to work as well...
it's fine if its hard to implement that that we skip it for now, but we should clarify that a bit more in the NEWS/docs. as written it will come as a surprise to users.
Member
Author
Good point. Changed it to support all of the following: by = .I
by = .(.I)
by = list(.I)
by = c(.I) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1732
edit: Current implementation supports: