5268_as_xts_support_non_numerics#5276
Merged
mattdowle merged 5 commits intoRdatatable:masterfrom Dec 2, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5276 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 77 77
Lines 14631 14645 +14
=======================================
+ Hits 14559 14573 +14
Misses 72 72
Continue to review full report at Codecov.
|
mattdowle
added a commit
that referenced
this pull request
Dec 3, 2021
| if (!all(colsNumeric)) warningf("Following columns are not numeric and will be omitted: %s", brackify(names(colsNumeric)[!colsNumeric])) | ||
| r = setDF(x[, .SD, .SDcols = names(colsNumeric)[colsNumeric]]) | ||
| return(xts::as.xts(r, order.by = if ("IDate" %chin% class(x[[1L]])) as.Date(x[[1L]]) else x[[1L]])) | ||
| r <- x[, -1L]# exclude first col, xts index |
Member
There was a problem hiding this comment.
sorry for the late review. would it be better to shallow()-copy x and then delete the first column?
|
|
||
| 51. `merge.data.table()` silently ignored the `incomparables` argument, [#2587](https://github.com/Rdatatable/data.table/issues/2587). It is now implemented and any other ignored arguments (e.g. misspellings) are now warned about. Thanks to @GBsuperman for the report and @ben-schwen for the fix. | ||
|
|
||
| 52. `as.xts.data.table` now supports non-numeric xts coredata matrixes, [5268](https://github.com/Rdatatable/data.table/issues/5268). Existing numeric only functionality is supported by a new `numeric.only` parameter, which defaults to `TRUE` for backward compatability and the most common use case. To convert non-numeric columns, set this parameter to `FALSE`. Conversions of `data.table` columns to a `matrix` now uses `data.table::as.matrix`, with all its performance benefits. Thanks to @ethanbsmith for the report and fix. |
Member
There was a problem hiding this comment.
Do we plan to support this numeric.only option indefinitely? If not, we should state the migration plan up front.
Contributor
Author
|
it is an extremely common use case. the numeric filter was in place for years and no one ever mentioned it as a problem. i only ran into the issue when i needed to use a boolean matrix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow bypass of numeric only columns
use
as.matrixfor fast conversionfixes #5268 (replaces pr: #5270)