Fix two "unusual" format warnings#5792
Merged
MichaelChirico merged 4 commits intomasterfrom Dec 6, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5792 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 80 80
Lines 14814 14814
=======================================
Hits 14439 14439
Misses 375 375 ☔ View full report in Codecov by Sentry. |
ben-schwen
reviewed
Dec 5, 2023
Merged
Member
Member
Well the warnings about fread.c:149:19 and assign.c:474:15 are gone! |
Member
Author
|
Taking that as success. I see the complex issues on dev and a new .Rbuildignore issue, nothing about format warnings. |
MichaelChirico
added a commit
that referenced
this pull request
Dec 6, 2023
* Fix two "unusual" format warnings * Add comment, find more %d usages * Update src/assign.c --------- Co-authored-by: jangorecki <j.gorecki@wit.edu.pl>
MichaelChirico
added a commit
that referenced
this pull request
Dec 6, 2023
* Fix two "unusual" format warnings (#5792) * Fix two "unusual" format warnings * Add comment, find more %d usages * Update src/assign.c --------- Co-authored-by: jangorecki <j.gorecki@wit.edu.pl> * fix * more %zu in gsumm --------- Co-authored-by: jangorecki <j.gorecki@wit.edu.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5790
I don't see clear answers about
DWORDbut it seems like%ldwill work:https://copyprogramming.com/howto/what-is-the-format-specifier-for-dword-c
For
TRUELENGTH()we wrote the comment about casting tolong longbut there is no cast. So trying to actually do the cast.