.SDcols is a negation only for _unary_ '-'#5881
Merged
jangorecki merged 4 commits intomasterfrom Jan 4, 2024
Merged
Conversation
Member
Author
|
Must admit I still don't understand the bug very well -- this incorrect assumption about unary So what changed to make it an error now that we didn't notice before? 🤷 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5881 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 80 80
Lines 14831 14831
=======================================
Hits 14457 14457
Misses 374 374 ☔ View full report in Codecov by Sentry. |
jangorecki
approved these changes
Jan 4, 2024
Member
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
Nice it got detected. It could be a mess having this bug to end up on CRAN. Hidden costs of NSE...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5826