Skip to content

Update Imports from Blanket to Selective Import for Improved Code Maintainability #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 7 commits into from
Mar 8, 2024
Merged

Update Imports from Blanket to Selective Import for Improved Code Maintainability #5988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ec78cf
Changed blanket imports to selective imports
Mar 7, 2024
1cc82d3
removed quotes
Mar 7, 2024
f97ac73
alphabetize
MichaelChirico Mar 7, 2024
d38e20d
removed time from imports
Mar 8, 2024
f171b0e
Update test.data.table.R
Nj221102 Mar 8, 2024
298aede
added name to Authors@R
Mar 8, 2024
2c9006a
Merge branch 'master' into side
MichaelChirico Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,6 @@ Authors@R: c(
person("Josh","O'Brien", role="ctb"),
person("Dereck","de Mezquita", role="ctb"),
person("Michael","Czekanski", role="ctb"),
person("Dmitry", "Shemetov", role="ctb")
person("Dmitry", "Shemetov", role="ctb"),
person("Nitish", "Jha", role="ctb")
)
6 changes: 3 additions & 3 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
useDynLib("data_table", .registration=TRUE)

## For S4-ization
import(methods)
importFrom(methods, "S3Part<-", slotNames)
exportClasses(data.table, IDate, ITime)
##

Expand Down Expand Up @@ -130,11 +130,11 @@ S3method(melt, default)
# and many packges on CRAN call dcast.data.table() and/or melt.data.table() directly. See #3082.
export(melt.data.table, dcast.data.table)

import(utils)
importFrom(utils, capture.output, contrib.url, download.file, flush.console, getS3method, head, packageVersion, tail, untar, unzip)
export(update_dev_pkg)
S3method(tail, data.table)
S3method(head, data.table)
import(stats)
importFrom(stats, as.formula, na.omit, setNames, terms)
S3method(na.omit, data.table)

S3method(as.data.table, xts)
Expand Down
2 changes: 1 addition & 1 deletion R/test.data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ test.data.table = function(script="tests.Rraw", verbose=FALSE, pkg=".", silent=F
}

# There aren't any errors, so we can use up 11 lines for the timings table
nTest = RSS = NULL # to avoid 'no visible binding' note
time = nTest = RSS = NULL # to avoid 'no visible binding' note
timings = env$timings[nTest>0]
if (!memtest) {
ans = head(timings[if (dev) -1L else TRUE][order(-time)], 10L)[,RSS:=NULL] # exclude id 1 in dev as that includes JIT
Expand Down