Tests robust to locale sorting#6074
Conversation
|
I did a PR to fix some tests on a machine where I run a French locale, #4719 |
|
I mentioned an approach like that in the linked issue: #3502 (comment) I might be missing something simpler, but the approach I was seeing to make the test reference depend on the locale was pretty abstruse, hence going with temporarily editing the locale. IIUC, in #4719, data.table and the reference value both depend on the underlying locale setting, which may be why it's easier to avoid temporary settings in that case. Here, data.table's value is completely independent of the setting. Actually, this discussion is reminding me that, because base R uses data.table's own code for |
Closes #3502.
@minemR it would be great if you could confirm this works on Windows as well, but I don't have any reason to believe there's an issue there.