Skip to content

exclude test for systems without longdouble support #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 4 commits into from
May 19, 2024
Merged

exclude test for systems without longdouble support #6137

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4045e8b
exclude test for systems without longdouble support
ben-schwen May 17, 2024
3b0f882
add comment about representability
ben-schwen May 19, 2024
efc762d
revert debug rprints
ben-schwen May 19, 2024
55eee5c
Merge branch 'master' into longdouble
MichaelChirico May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17876,9 +17876,11 @@ test(2225.2, groupingsets(data.table(iris), j=mean(Sepal.Length), by=c('Sp'='Spe
# make gprod work for bit64, #5225
if (test_bit64) {
test(2226.1, base::prod(2147483647L,2L), 4294967294) # just to illustrate that base returns double
DT = data.table(x=c(lim.integer64(), 2, 1, NA, NA, -2, 4), g=INT(1,2,1,2,1,2,3,3))
DT = data.table(x=c(lim.integer64(), 2, 1, NA, NA, -2, 4), g=INT(1,2,1,2,1,2,3,3)) # lim.integer64() not representable with long double having less than 64 bit
test(2226.2, DT[, prod(x), g], data.table(g=1:3, V1=as.integer64(c(NA,NA,-8L))))
test(2226.3, DT[, prod(x,na.rm=TRUE), g], data.table(g=1:3, V1=as.integer64(c(NA,"9223372036854775807",-8L))))
if (test_longdouble) {
Comment thread
MichaelChirico marked this conversation as resolved.
test(2226.3, DT[, prod(x,na.rm=TRUE), g], data.table(g=1:3, V1=as.integer64(c(NA,"9223372036854775807",-8L))))
}
}

# set ops when DT has column names x and y, #5255
Expand Down