Don't include po/ directory in bundled package#6331
Merged
MichaelChirico merged 2 commits intomasterfrom Aug 1, 2024
Merged
Conversation
tdhock
approved these changes
Aug 1, 2024
Member
tdhock
left a comment
There was a problem hiding this comment.
great thanks
maybe ask about this on R-devel or R-pkg-devel?
Member
Author
|
I thought of it, but I think the reason is -- R doesn't want to/can't assume every package has its source tracked on GitHub/openly online. So including po/ by default is the easiest way to give end users access to the .po/.pot files of every CRAN package. Put another way, if I put my package on CRAN, but keep its sources private, end users can get .mo files but it's quite difficult for them to offer me new translations (basically they'd have to contact me individually and we share .pot/.po privately). Therefore, while I think it's indeed best practice for packages to exclude it, I doubt R-core will consider this idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why R doesn't do this by default, but certainly we don't need to include these files -- certainly
R CMD checkdoesn't care.