Skip to content

Don't include po/ directory in bundled package#6331

Merged
MichaelChirico merged 2 commits intomasterfrom
ignore-po
Aug 1, 2024
Merged

Don't include po/ directory in bundled package#6331
MichaelChirico merged 2 commits intomasterfrom
ignore-po

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

I don't know why R doesn't do this by default, but certainly we don't need to include these files -- certainly R CMD check doesn't care.

Copy link
Copy Markdown
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks
maybe ask about this on R-devel or R-pkg-devel?

@MichaelChirico
Copy link
Copy Markdown
Member Author

I thought of it, but I think the reason is -- R doesn't want to/can't assume every package has its source tracked on GitHub/openly online. So including po/ by default is the easiest way to give end users access to the .po/.pot files of every CRAN package.

Put another way, if I put my package on CRAN, but keep its sources private, end users can get .mo files but it's quite difficult for them to offer me new translations (basically they'd have to contact me individually and we share .pot/.po privately).

Therefore, while I think it's indeed best practice for packages to exclude it, I doubt R-core will consider this idea.

@MichaelChirico MichaelChirico merged commit c36c84f into master Aug 1, 2024
@MichaelChirico MichaelChirico deleted the ignore-po branch August 1, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants