Skip to content

Link fix in vignettes for CRAN checks#6404

Merged
MichaelChirico merged 3 commits intomasterfrom
cran1-16-pr
Aug 27, 2024
Merged

Link fix in vignettes for CRAN checks#6404
MichaelChirico merged 3 commits intomasterfrom
cran1-16-pr

Conversation

@TysonStanley
Copy link
Copy Markdown
Member

Closes #6166 with minor changes to vignettes

@MichaelChirico
Copy link
Copy Markdown
Member

I see 1.16.0 on CRAN, is this going to be part of a patch?

@TysonStanley
Copy link
Copy Markdown
Member Author

No, this was part of the release to CRAN to pass the checks.

@MichaelChirico
Copy link
Copy Markdown
Member

Oh, got it. 8f39d2c didn't make it in, right? Should we revert that so it's not included in the 1.16.0 tag?

@TysonStanley
Copy link
Copy Markdown
Member Author

No, that one did not make it. Might make sense to revert for that reason and then recommit in 1.16.99

@MichaelChirico MichaelChirico merged commit 534fc18 into master Aug 27, 2024
@MichaelChirico MichaelChirico deleted the cran1-16-pr branch August 27, 2024 05:59
@TysonStanley
Copy link
Copy Markdown
Member Author

Note that the tag is now live on GitHub based on the submitted version. Outside of version bumps and compression, any other changes are now on master (after you merged this). Other version bumps will need to be done to 1.16.99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release data.table version 1.16.0

2 participants