Skip to content

Add a GHA to prevent backsliding on translation compilation#6415

Merged
MichaelChirico merged 1 commit intomasterfrom
lint-mo
Aug 31, 2024
Merged

Add a GHA to prevent backsliding on translation compilation#6415
MichaelChirico merged 1 commit intomasterfrom
lint-mo

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Follow-up to #6414.

I'm not 100% sure how stable the MD5 sum of the .mo binary is. But let's try & see. If that causes issues, we can probably use the msgunfmt output instead. If that's unstable too, we'll probably switch to {potools}, which can read the .po output of msgunfmt as a data.table where we can use all.equal() after appropriate normalization.

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Aug 27, 2024
@MichaelChirico MichaelChirico changed the base branch from compile-mo to 08-29-skip_checking_.po_file_if_it_s_not_edited_on_the_current_branch August 29, 2024 05:07
Copy link
Copy Markdown
Member Author

MichaelChirico commented Aug 29, 2024

@MichaelChirico
Copy link
Copy Markdown
Member Author

It's not tested here (because the code-quality GHA only runs on PRs targeting master), but this should get GHA back to ✅. Merging the full stack now.

@MichaelChirico MichaelChirico force-pushed the 08-29-skip_checking_.po_file_if_it_s_not_edited_on_the_current_branch branch from 416474f to 919d75d Compare August 31, 2024 17:23
@MichaelChirico MichaelChirico force-pushed the 08-29-skip_checking_.po_file_if_it_s_not_edited_on_the_current_branch branch 2 times, most recently from fad1de6 to e944c44 Compare August 31, 2024 17:26
@MichaelChirico MichaelChirico changed the base branch from 08-29-skip_checking_.po_file_if_it_s_not_edited_on_the_current_branch to graphite-base/6415 August 31, 2024 17:27
@graphite-app graphite-app bot changed the base branch from graphite-base/6415 to master August 31, 2024 17:27
Copy link
Copy Markdown
Member Author

Merge activity

@MichaelChirico MichaelChirico deleted the lint-mo branch August 31, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation issues/PRs related to message translation projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant