Add a GHA to prevent backsliding on translation compilation#6415
Merged
MichaelChirico merged 1 commit intomasterfrom Aug 31, 2024
Merged
Add a GHA to prevent backsliding on translation compilation#6415MichaelChirico merged 1 commit intomasterfrom
MichaelChirico merged 1 commit intomasterfrom
Conversation
874514f to
098d468
Compare
86ed161 to
383aa9a
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on |
This was referenced Aug 29, 2024
1a7e9ee to
416474f
Compare
383aa9a to
8386546
Compare
Member
Author
|
It's not tested here (because the |
416474f to
919d75d
Compare
8386546 to
6c1b7ac
Compare
fad1de6 to
e944c44
Compare
6c1b7ac to
41c6bf3
Compare
41c6bf3 to
01b6035
Compare
01b6035 to
1e559ef
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #6414.
I'm not 100% sure how stable the MD5 sum of the .mo binary is. But let's try & see. If that causes issues, we can probably use the
msgunfmtoutput instead. If that's unstable too, we'll probably switch to {potools}, which can read the .po output ofmsgunfmtas a data.table where we can useall.equal()after appropriate normalization.