Don't attempt reuseSorting on non-data.table in bmerge#6502
Merged
MichaelChirico merged 2 commits intomasterfrom Sep 17, 2024
Merged
Don't attempt reuseSorting on non-data.table in bmerge#6502MichaelChirico merged 2 commits intomasterfrom
MichaelChirico merged 2 commits intomasterfrom
Conversation
|
Generated via commit 4be998f Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 36 seconds Time taken to run |
Member
Author
|
@jangorecki merging this since "it works" to include it in the patch, but please do follow up if you see a better fix & we can apply it later. |
Member
|
Interesting one, I don't have any better fix for now, we should probably start with understanding the issue better to figure out better fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6501.
I still don't see why having an extended class like
tbl_dfis necessary, i.e. why plaindata.framedoesn't wind up here. Maybe Jan sees a more robust diagnosis.