Inconsistent code formatting / minor fixes to vignettes#6521
Merged
MichaelChirico merged 12 commits intoRdatatable:masterfrom Sep 23, 2024
Merged
Inconsistent code formatting / minor fixes to vignettes#6521MichaelChirico merged 12 commits intoRdatatable:masterfrom
MichaelChirico merged 12 commits intoRdatatable:masterfrom
Conversation
Since you're updating the vignette i add a minor tweak,
aitap
reviewed
Sep 22, 2024
Anirban166
reviewed
Sep 22, 2024
MichaelChirico
approved these changes
Sep 23, 2024
Member
|
Nice finds all! Thanks for filing. Our rule is to add as Members anyone making code contributions; this current PR (while certainly highly valued!) doesn't qualify (doc-only), however, your earlier #4129 does (and I see you were already added to DESCRIPTION then). Therefore I invited you to join as a member! That'll make things easier e.g. by allowing you to create branches directly on this repo. Thank you! |
MichaelChirico
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed 1 inconsistent code formatting issue and a few broken links in RMarkdown Vignettes.