Skip to content

Implementation for special on= warning#7093

Closed
MichaelChirico wants to merge 1 commit intomasterfrom
merge-on-warn
Closed

Implementation for special on= warning#7093
MichaelChirico wants to merge 1 commit intomasterfrom
merge-on-warn

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Jun 24, 2025

Closes #7088

Honestly, this is pretty insanely over-convoluted. I don't think it should be merged.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.62%. Comparing base (495ffd4) to head (697316c).

Files with missing lines Patch % Lines
R/merge.R 42.10% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7093      +/-   ##
==========================================
- Coverage   98.69%   98.62%   -0.08%     
==========================================
  Files          79       79              
  Lines       14688    14702      +14     
==========================================
+ Hits        14497    14500       +3     
- Misses        191      202      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge.data.table no error when "on" instead of "by" and merge on all common vars empty

1 participant