as.data.table.array: copy shared dimnames before reversing them #7509
Merged
ben-schwen merged 2 commits intomasterfrom Dec 23, 2025
Merged
as.data.table.array: copy shared dimnames before reversing them #7509ben-schwen merged 2 commits intomasterfrom
as.data.table.array: copy shared dimnames before reversing them #7509ben-schwen merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7509 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 87 87
Lines 16704 16705 +1
=======================================
+ Hits 16544 16545 +1
Misses 160 160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelChirico
approved these changes
Dec 23, 2025
Member
MichaelChirico
left a comment
There was a problem hiding this comment.
was there not a place to just change setfrev() to frev() to get the copy?
Generated via commit 036b8e1 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
Author
|
Given that it took me three tries to get both tests to pass, maybe replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes: #7506. Tested by installing HEAD of this PR and re-running
R CMD check ctsem_*.tar.gz. It still fails tests on my machine, but due to unrelated problems inparallellycluster startup, not indata.table. Previously,setfrev()could be called on eitherdimnames(x)or a list that sharednames(dimnames(x)), mutatingxas a result.