Add polyresistor primitive with GF180MCU support#61
Add polyresistor primitive with GF180MCU support#61ErinXU2004 wants to merge 5 commits intoReaLLMASIC:mainfrom
Conversation
ErinXU2004
commented
Oct 14, 2025
ErinXU2004
commented
- Add polyres.py: polyresistor primitive implementation
- Update gf180_mapped.py: add polyresistor models and layers
- Update gf180_grules.py: add polyresistor design rules
- Update mappedpdk.py: add polyresistor layer validation
- Polyresistor supports both silicided and unsilicided types
- DRC clean on kLayout
- Add polyres.py: polyresistor primitive implementation - Update gf180_mapped.py: add polyresistor models and layers - Update gf180_grules.py: add polyresistor design rules - Update mappedpdk.py: add polyresistor layer validation - Clean branch based on upstream/main (no docker_testing folder) - Polyresistor supports both silicided and unsilicided types - Includes proper netlisting and DRC compliance
|
|
- Move test code from polyres.py to dedicated test folder - Create tests/regression/test_polyres_multifinger.py with parameterized tests - Add comprehensive test coverage for M1.2a spacing fix - Include tests for various widths (0.5, 0.8, 1.0, 1.5 µm) - Include tests for various finger counts (2, 3, 5, 7) - All tests are fully parameterized and configurable - Add detailed README.md with usage examples - Addresses code review request to add tests to regression test folder
- Clean up ATLAS-related files from blocks/ATLAS directory - These files were specific to dataset generation workflow - Keep repository focused on core gLayout functionality
|
Hi Erin, I’ve been reviewing some older PRs, and I want to say that your work is valuable and we would definitely like to merge it. Since this branch was opened, the repository structure and organization have changed quite a bit over several updates, so the PR in its current form is no longer aligned cleanly with the current codebase. I think the polyres support is still worth keeping, and it would probably be best to split that part out and rebase/adapt it to the current repository structure before merging. That would make it much easier for us to review, test, and integrate properly. Thanks! |
Yes! Just go ahead and do it!! |
4 participants
