Skip to content

Fix: remove anchor when data-tooltip-id gets changed#1153

Merged
gabrieljablonski merged 1 commit intoReactTooltip:masterfrom
mixrich:fix/remove-anchor-if-no-longer-there
Jan 21, 2024
Merged

Fix: remove anchor when data-tooltip-id gets changed#1153
gabrieljablonski merged 1 commit intoReactTooltip:masterfrom
mixrich:fix/remove-anchor-if-no-longer-there

Conversation

@mixrich
Copy link
Contributor

@mixrich mixrich commented Jan 18, 2024

When data-tooltip-id gets updated from A to B for the same DOM element, the A still continues showing the tooltip when it isn't expected. The PR fixes that, now A will properly untrack the tooltip when data-tooltip-id becomes not A

UPD: I see some failed tests. Looks like one test uses the outdated snapshot, the second one seems to be flaky. The same happens in master as well

@gabrieljablonski
Copy link
Member

Thanks for your contribution!

Some quick testing shows this works as expected. After @danielbarion also approves it, we'll merge a do a release.


UPD: I see some failed tests. Looks like one test uses the outdated snapshot, the second one seems to be flaky. The same happens in master as well

Yep, we've got some open issues with our test specs, don't worry about those.

@gabrieljablonski gabrieljablonski merged commit 6d2a880 into ReactTooltip:master Jan 21, 2024
@mixrich
Copy link
Contributor Author

mixrich commented Jan 23, 2024

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants