BlockingObservable#272
Merged
benjchristensen merged 6 commits intoMay 16, 2013
Merged
Conversation
- see ReactiveX#270 for background
|
RxJava-pull-requests #144 FAILURE |
|
RxJava-pull-requests #145 SUCCESS |
Member
Author
|
Apparently another non-deterministic test |
Member
Author
|
I plan on merging this tomorrow morning (Thursday, May 16th Pacific time) if no strong reasons are given for not proceeding. |
Member
Author
|
No feedback to argue against proceeding so merging now... |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
BlockingObservable
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…matchers fix (ReactiveX#271): remove deprecated usage of Mockito Matchers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all blocking operators to
BlockingObservable. This has breaking changes for anything using blocking operators ... part of the pursuit of establishing a clean API on our path to 1.0.This is something I've been wanting to do for a while but got the push over the ledge via discussion at #270.
This strays from "match Rx.Net as closely as possible" but feels justified for the following reasons:
takeandtakeLastis non-obvious)I have removed all blocking operators from
Observableand put them inBlockingObservable. I have leftObservable.toBlockingObservableas a means of going from one to the other as it is an obvious communication of what is now being permitted.While doing this I also cleaned up some odd API artifacts such as
toObservablevsfromand moved implementation specific code fromrx.utilinto the internal packagerx.operatorswhere all code reserves the right to change at any time.I intend on releasing this as version 0.9.