Skip to content

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 8, 2020

The outer onError did not cancel the inner sources. The Observable variant works correctly but both received an unit test to verify the behavior.

2.x will be fixed in a separate PR.

Related #6825

@akarnokd akarnokd added this to the 3.0 milestone Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #6826 into 3.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6826      +/-   ##
============================================
- Coverage     98.27%   98.26%   -0.01%     
- Complexity     6378     6383       +5     
============================================
  Files           715      715              
  Lines         46482    46485       +3     
  Branches       6371     6373       +2     
============================================
  Hits          45678    45678              
- Misses          285      287       +2     
- Partials        519      520       +1
Impacted Files Coverage Δ Complexity Δ
...3/internal/operators/flowable/FlowableFlatMap.java 90.08% <100%> (+0.08%) 4 <0> (ø) ⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.9% <0%> (-8.26%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-6.34%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 89.68% <0%> (-3.18%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 93.02% <0%> (-1.17%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
.../operators/observable/ObservableCombineLatest.java 96.17% <0%> (-0.64%) 6% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 89.96% <0%> (-0.34%) 3% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 97.41% <0%> (ø) 6% <0%> (ø) ⬇️
...a3/internal/operators/flowable/FlowableReplay.java 92.81% <0%> (+0.82%) 19% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84677c5...b74203d. Read the comment docs.

@akarnokd akarnokd merged commit 6030d83 into ReactiveX:3.x Jan 8, 2020
@akarnokd akarnokd deleted the FlatMapInnerCancelFix3x branch January 8, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants