docs(operators): add documentation for bufferWhen#236
docs(operators): add documentation for bufferWhen#236sumitarora merged 7 commits intoReactiveX:masterfrom
Conversation
…#113 Add documentation for operator bufferWhen to close ReactiveX#113 ReactiveX#113
DiedrikDM
changed the title
|
Apparently when Travis is currently trying to build the application there is a module "@ angular-devkit/core" missing from the list. I believe this is caused by the angular cli, but can easily be solved by including the missing module as a devDependency. |
Add dependency for @angular-devkit/core to fix the Travis CI build
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 77.14% 77.14%
=======================================
Files 15 15
Lines 175 175
Branches 7 7
=======================================
Hits 135 135
Misses 40 40Continue to review full report at Codecov.
|
DiedrikDM
changed the title
As an temporary solution I added @angular-devkit/core as a devDependency to solve the build issues from Travis. However, I now changed the package.json to include the latest angular-cli version (to 1.6.5) and this allows Travis to build correctly. I find this a better solution than the previous one
The related operators was listing windowTime, but instead should be listing windowWhen
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@angular/cli": "1.6.0", | ||
| "@angular/cli": "1.6.5", |
There was a problem hiding this comment.
CLI update is another PR too. Could you remove it from the other one.
There was a problem hiding this comment.
@sumitarora Just to be sure: I understood this comment correctly to leave the CLI update in this PR but modify the other ones so they don't include it anymore right?
| map(e => {return {x: e.clientX, y: e.clientY};}), | ||
| bufferWhen(() => interval(1000 + Math.random() * 4000)) | ||
| ) | ||
| buffered$.subscribe(x => console.log(x)); |
There was a problem hiding this comment.
Please add expected output for jsbin.
Added comment in the documentation as requested to contain the expected console output. Removed the $ suffix from the examples for now for consistency (wait for coding guidelines).
The expected console output should be after the subscription. Also deleted the generics from the method signature.
4 participants
Add documentation for operator bufferWhen to close #113
#113