This repository was archived by the owner on Oct 1, 2018. It is now read-only.
chore(tooling): Add prettier, lint-staged and precommit hook for tooling#49
Merged
ladyleet merged 1 commit intoReactiveX:masterfrom Oct 21, 2017
Merged
Conversation
Collaborator
Author
|
cc @kwonoj |
ladyleet
approved these changes
Oct 20, 2017
Member
|
LGTM. @kwonoj ? (Thx @ashwin-sureshkumar ) |
|
Would it sense to run the tests in the pre-commit hook? |
Collaborator
Author
Member
No. Commit occurs quite frequent and commit chunk can create test failures will make daily flow painful. |
Member
|
@ashwin-sureshkumar can you update the branch pls? |
- Added basic tooling configuration for linting using prettier, tslint. - Added precommit to run lint on staged files Close ReactiveX#45
ashwin-sureshkumar
force-pushed
the
issue-45
branch
from
f49eece to
99b382b
Compare
Collaborator
Author
|
@ladyleet - Done ! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #45