refactor(types): enable strict fntype compiler option#3050
refactor(types): enable strict fntype compiler option#3050benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
Generated by 🚫 dangerJS |
---5.9KB-green.svg?style=flat-square){kind=icon}
---0.5KB-green.svg?style=flat-square){kind=icon}
|
I understand eveyone is busy, but can we get this reviewed early? I understand there's a workaround but its suboptimal. |
|
I forgot this :/ and I'm sure this'll require to resolve merge conflict with #3145. Anyway, this is for v6 branch and not for stable, for 5.x probably we need small scoped change only resolve issue. |
|
Oh, okay, thanks for clarifying. |
|
Well the new year is here, and as I see it the #3145 that is causing the conflicts only moves files around, so what is needed to do is move the files this PR changed into the new locations? I really agree this should be also back-ported into 5.x, this issue breaks rxjs completely in typescript 2.6.1 |
|
uh-oh, this PR itself even have huge conflict due to recent changes. I need to rebase this first, then picks some into 5.5 |
| const creationState: CreationState<T> = { windowTimeSpan, windowCreationInterval, subscriber: this, scheduler }; | ||
| this.add(scheduler.schedule(dispatchWindowClose, windowTimeSpan, closeState)); | ||
| this.add(scheduler.schedule(dispatchWindowCreation, windowCreationInterval, creationState)); | ||
| this.add(scheduler.schedule<CloseState<T>>(dispatchWindowClose, windowTimeSpan, closeState)); |
There was a problem hiding this comment.
This smells a little. I feel like all of this should be cleaner.
|
|
Good add, 
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Description:
This PR enables
strictFnTypein master branch resolves build error with 2.6 version of tsc. (related with #3031) . due to our inheritance structure, there are some types are actually loosened (mostly aroundAction'sworktypes).This is targeting master intentionally due to scope of change is relatively large, include (probably) unnecessary part to close issue itself. Some change need to be cherrypicked into
stablethough.Related issue (if exists):