Merged
Conversation
Moves all patching operator implementations to a directory `internal/patching/operator`. BREAKING CHANGE: Deep imports to `rxjs/operator/*` (NOT `rxjs/operators/*`!!!) will no longer work. Again, pipe operators are still where they were.
…ctory
- Moves all files from `src/observables` to `src/internal/observables`
- Updates some tests to reference those internal files, this is
temprorary
- Adds an `index.ts` file at root that exports the static observable
creation functions
BREAKING CHANGE: You can no longer import observables from
`rxjs/observable/*`, now you must import them from `rxjs` directly, like
so: `import { fromEvent, timer } from 'rxjs';`
BREAKING CHANGE: You should no longer deep import custom Observable
implementations
BREAKING CHANGE: `_throw` is now exported as `throwError`
BREAKING CHANGE: `if` is now exported as `iif`
- Exports all pipeable operators from `rxjs`.
BREAKING CHANGE: Pipeable operators must now be imported from `rxjs`
like so: `import { map, filter, switchMap } from 'rxjs';`
BREAKING CHANGE: Operator versions of static observable creators such as
`merge`, `concat`, `zip`, `onErrorResumeNext`, and `race` have been
removed. Please use the static versions of those operations. e.g.
`a.pipe(concat(b, c))` becomes `concat(a, b, c)`.
- Exports schedulers as `asapScheduler`, `asyncScheduler`, `queueScheduler` and `animationFrameScheduler` BREAKING CHANGE: Scheduler instances have changed names to be suffixed with `Scheduler`, (e.g. `asap` -> `asapScheduler`)
- moves operators directory under `internal`. - moves `operators.ts` to `internal/operators/index.ts`
BREAKING CHANGE: Can no longer deep import top-level types such as `rxjs/Observable`, `rxjs/Subject`, `rxjs/ReplaySubject`, et al. All imports should be done directly from `rxjs`, for example: `import \{ Observable, Subject \} from 'rxjs';`
Generated by 🚫 dangerJS |
---3.3KB-green.svg?style=flat-square){kind=icon}
-+0.1KB-red.svg?style=flat-square){kind=icon}
BREAKING CHANGE: Symbols are no longer exported directly from modules such as `rxjs/symbol/observable` please use `Symbol.observable` and `Symbol.iterator` (polyfills may be required)
BREAKING CHANGE: Can no longer explicitly import types from `rxjs/interfaces`, import them from `rxjs` instead
BREAKING CHANGE: THIS NEGATES THE PREVIOUS BREAKING CHANGES TO OPERATOR MOVE TO `rxjs`, UPDATE CHANGELOG ON RELEASE
BREAKING CHANGE: All create functions such as `of`, `from`, `combineLatest` and `fromEvent` should now be imported from `rxjs/create`.
BREAKING CHANGE: `HotObservable` and `ColdObservable`, and other testing support types are no longer exported directly.
BREAKING CHANGE: Many internal use utilities like `isArray` are now hidden under `rxjs/internal`, they are implementation details and should not be used.
BREAKING CHANGE: Ajax observable should be imported from `rxjs/ajax`.
…ebsocket` BREAKING CHANGE: `webSocket` creator function now exported from `rxjs/websocket` as `websocket`.
kwonoj
approved these changes
Jan 12, 2018
rgbkrk
approved these changes
Jan 12, 2018
18 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A continuation of #3145.
I had an issue with my fork, so I needed to start the PR over because Github didn't give me any other options. It's all the same commits, and the same conversations apply.
Continuing work here.
Also, it's rebased instead of having that merge commit
See commit messages for more details.
Exports from a few places:
rxjscommon types, schedulers and utilitiesrxjs/createstatic creation methods likeof,from,concat,forkJoin,fromEvent, etcrxjs/operatorsall of the pipeable operatorsrxjs/ajaxthe ajax implementationrxjs/websocketthe web socket implementationRemoves operator versions of observable creation helpers (use
concat(a, b, c)instead ofa.pipe(concat(b, c)))Moves things people should not be importing directly into an "internal" directory, so it's more obvious you're doing something silly.