Skip to content

Add underscores for Windows tile config #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phbernard merged 4 commits into from
Mar 31, 2021
Merged

Add underscores for Windows tile config #26

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e52b881
Add underscores for Windows tile config
Feb 7, 2021
00b2447
Exclude color values from regex pattern
Feb 7, 2021
3797385
explicitly exclude colors from underscore conversion
Feb 7, 2021
a0b2602
put array closing bracket on newline to avoid potential merge conflicts
Feb 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ module.exports.init = function() {
};

exports.camelCaseToUnderscore = function(s) {
return s.replace(/(?:^|\.?)([A-Z])/g, function(x,y) {
// Regex will also insert an underscore before a digit if that digit is preceded by a lowercase letter and followed
// by one or more additional digits, so it will insert an underscore before the "8" and the "1" in
// "windows80Ie10Tile" (yielding "windows_80_ie_10_tile", but NOT before the "6" in "ios6AndPriorIcons" (yielding
// "ios6_and_prior_icons").
return s.replace(/(?:^|\.?)([A-Z]|(?<=[a-z])\d(?=\d+))/g, function(x,y) {
return "_" + y.toLowerCase()
}).replace(/^_/, "");
}
Expand Down Expand Up @@ -150,7 +154,10 @@ module.exports.init = function() {
'app_description',
'developer_name',
'app_name',
'existing_manifest'];
'existing_manifest',
'background_color',
'theme_color'
];
var newContent = (keysToIgnore.indexOf(uKey) >= 0)
? request[key]
: exports.camelCaseToUnderscoreRequest(request[key]);
Expand Down