prodeng-323 response handling refactor #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rve as the baseline for all the other SDKs, so they all should return the same or similar error messages for the same conditions
mabeledo
requested review from
rustybrooks-realitydefender,
rweindl and
sfusco-realitydefender
rustybrooks-realitydefender
approved these changes
Jul 26, 2025
Contributor
rustybrooks-realitydefender
left a comment
rustybrooks-realitydefender
left a comment
There was a problem hiding this comment.
LGTM - it looks like the BasicResponse class isn't used though, so I'd either remove it, or plug it in to the place(s) where it would make sense
sfusco-realitydefender
approved these changes
Jul 26, 2025
mabeledo
deleted the
manuel/prodeng-323-python-show-proper-error-message-when-user-try-to-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typesformodelbecause Mypy couldn't stop complaining about having a module withtypein the name.