fix: handle duplicate room creation race condition #157
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch 23505 unique constraint error when frontend creates room before backend's selectRoom sees it. Skip notification if room already exists.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Braintrust eval reportCatalog Opportunity Analysis Evaluation (HEAD-1769483992)
Catalog Songs Count Evaluation (HEAD-1769483992)
First Week Album Sales Evaluation (HEAD-1769483992)
Memory & Storage Tools Evaluation (HEAD-1769483992)
Monthly Listeners Tracking Evaluation (HEAD-1769483992)
Search Web Tool Evaluation (HEAD-1769483992)
Social Scraping Evaluation (HEAD-1769483992)
Spotify Followers Evaluation (HEAD-1769483992)
Spotify Tools Evaluation (HEAD-1769483992)
TikTok Analytics Questions Evaluation (HEAD-1769483992)
|
Contributor
There was a problem hiding this comment.
why are you removing the promise.all?
Simpler fix - keep parallel execution, only catch the 23505 error.
This is the actual fix - createNewRoom is called during setupConversation at request START, which is where the 500 error occurs.
Frontend no longer creates rooms, so no race condition. Backend is single source of truth for room creation.
- Changed insertRoom to use upsert with ignoreDuplicates: true - Reverted try/catch in createNewRoom.ts and handleChatCompletion.ts - Cleaner solution: duplicates are silently ignored at the DB level
One-line fix: change insert to upsert in insertRoom.ts. Removes try/catch workarounds since upsert handles duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Intermittent 500 errors on new chat due to
duplicate key value violates unique constraint "rooms_pkey".Root Cause
Frontend and backend both try to create the same room:
Recoup-Chat/app/api/chat/create/route.ts→ Creates room for optimistic UIRecoup-API/lib/chat/handleChatCompletion.ts→ Also creates room (for API clients)Race condition: backend's
selectRoom()returns null before frontend's insert is visible → duplicate key error.Solution
Catch the 23505 (unique constraint violation) error in
handleChatCompletion. If room already exists, skip notification and continue - the frontend already created it.Changes
insertRoomin try/catchRelated
refetchConversations()toonFinishto sync title updates