Open
Conversation
Usage of std::function to call listeners
Handles SDL window
NFD library handler
Modules and unnamed namespaces do not require the variable to be static, it´s redundant
Cannot repro this exception anymore, maybe rebooting the system solved it.
Currently there is not any error handling for invalid json
linux will compile as debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the CI/CD workflow and build configuration to support cross-platform builds and enable code coverage reporting. The most important changes include updates to the
sonarcloud.ymlworkflow file and modifications to theCMakeLists.txtfile.CI/CD Workflow Updates:
.github/workflows/sonarcloud.yml: Updated the job matrix to support both Windows and Linux builds, including setting specific environment variables and build wrappers for each OS..github/workflows/sonarcloud.yml: Added steps to install dependencies for Linux and Windows separately, ensuring the correct tools and compilers are available for each platform..github/workflows/sonarcloud.yml: Modified theCreate sonar-project.propertiesstep to use bash instead of PowerShell and added logic to include coverage report paths for Linux builds..github/workflows/sonarcloud.yml: Added steps to run tests and generate coverage reports specifically for Linux builds.Build Configuration:
CMakeLists.txt: Introduced an option to enable code coverage reporting, including adding coverage flags, debug symbols, and disabling optimizations when the option is enabled.