fix: skip go-version check when workflow has no go-version field#103
Merged
lenasolarova merged 1 commit intoApr 24, 2026
Conversation
The check was extended to cover gotests.yml (in addition to gotests.yaml) but repos whose workflows use a UBI container instead of setup-go do not declare go-version, causing the check to fail with an empty comparison. Skip gracefully when go-version is not present, consistent with how the check already handles missing workflow files and reusable workflows. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
juandspy
approved these changes
Apr 24, 2026
ikerreyes
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the check was extended to cover
gotests.yml(in addition togotests.yaml), repos whose workflows use a UBI container instead ofactions/setup-godo not declarego-version:. The check then fails comparing the Dockerfile version against an empty string.This broke the MintMaker pre-commit hooks bump PR in parquet-factory (#52) which has
gotests.ymlusingubi9/go-toolset— a pattern that was silently skipped before because v0.1.0 only checked forgotests.yaml.Fix
Skip gracefully when
go-versionis not declared in the workflow file, consistent with how the check already handles missing workflow files and reusable workflows. Repos that do declarego-versioncontinue to have their versions enforced as before.