fix: always upload coverage to Codecov even if threshold check fails#107
Merged
lenasolarova merged 2 commits intoApr 24, 2026
Merged
Conversation
The Codecov upload step was gated after the coverage threshold check. When a PR fails the threshold, the upload never ran, so Codecov posted no comments and showed no checks on those PRs. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe GitHub Actions workflow Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Coverage check now uses continue-on-error so the job does not fail on threshold violations. Codecov always receives the report regardless of coverage level, giving visibility without blocking merges. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
juandspy
approved these changes
Apr 24, 2026
ikerreyes
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Codecov upload step ran after the coverage threshold check. When a PR failed the threshold, the job exited early and the Codecov upload never ran — so Codecov posted no PR comments and showed no checks.
Additionally, a failing coverage threshold was blocking PR merges entirely.
Fix
Add
continue-on-error: trueto the coverage threshold step. The check still runs and logs the result, but it no longer blocks the job. Codecov always receives the report, giving visibility into coverage trends without gating merges on an arbitrary threshold.