Skip to content

Expose secret within the reusable workflow in order to use repos secrets #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joselsegura merged 1 commit into from
May 5, 2026
Merged

Expose secret within the reusable workflow in order to use repos secrets #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/gotests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ name: Go tests

on:
workflow_call:
secrets:
CODECOV_TOKEN:
required: false
Comment thread
ikerreyes marked this conversation as resolved.

inputs:
coverage:
Expand Down
4 changes: 3 additions & 1 deletion workflows_examples/gotests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@ on:

jobs:
gotests:
uses: RedHatInsights/processing-tools/.github/workflows/gotests.yaml@v0.4.1
uses: RedHatInsights/processing-tools/.github/workflows/gotests.yaml@v0.4.2
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether workflow references are pinned to immutable SHAs or mutable refs.
# Expected: no `uses:` entries ending with `@v`* / `@main` / `@master` for reusable workflows.
rg -nP --type=yaml '^\s*uses:\s*[^#\s]+/(?:\.github/workflows/[^@\s]+)@([A-Za-z0-9._-]+)\s*$' .github workflows_examples -C2

Repository: RedHatInsights/processing-tools

Length of output: 1688

Pin reusable workflow to an immutable commit SHA, not a mutable tag.

Using @v0.4.2 allows retagging and weakens supply-chain integrity for CI. Prefer @<full_sha> for deterministic and safer runs.

🔧 Proposed change 
-    uses: RedHatInsights/processing-tools/.github/workflows/gotests.yaml@v0.4.2
+    uses: RedHatInsights/processing-tools/.github/workflows/gotests.yaml@<full_commit_sha>
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@workflows_examples/gotests.yaml` at line 8, The workflow currently references
a mutable tag
"RedHatInsights/processing-tools/.github/workflows/gotests.yaml@v0.4.2" which
weakens CI supply-chain integrity; update the uses reference to the
corresponding immutable full commit SHA (replace "@v0.4.2" with
"@<full_commit_sha>") so the reusable workflow is pinned to a specific commit,
e.g., change the string in the uses key to
"RedHatInsights/processing-tools/.github/workflows/gotests.yaml@<full_sha>"
ensuring deterministic runs.

secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Loading