Skip to content

Fix mispelled option for BDD workflows#162

Merged
joselsegura merged 1 commit into
RedHatInsights:masterfrom
joselsegura:fix-mispeled-option
May 11, 2026
Merged

Fix mispelled option for BDD workflows#162
joselsegura merged 1 commit into
RedHatInsights:masterfrom
joselsegura:fix-mispeled-option

Conversation

@joselsegura
Copy link
Copy Markdown
Contributor

Description

Fix issue when creating several BDD tests with wrong option

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration update

Testing steps

@joselsegura joselsegura requested a review from a team as a code owner May 11, 2026 11:29
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Summary by CodeRabbit

  • Chores
    • Fixed configuration typo in workflow synchronization settings.
    • Added new automated workflow template for enhanced testing capabilities.

Walkthrough

The sync configuration corrects a misspelled use_posrgres parameter to use_postgres across three synced workflow templates and adds a new workflow sync target for the DVO writer service with Kafka and PostgreSQL enabled.

Changes

Configuration Typo Corrections and DVO Workflow Sync

Layer / File(s) Summary
Configuration Fixes
.github/sync.yml (lines 179–228)
Corrected use_posrgresuse_postgres in three repository configurations: insights-results-aggregator, insights-results-aggregator-cleaner, and insights-results-aggregator-exporter. Added new sync target for bdd-dvo.yaml workflow with dvo-writer service, use_kafka: true, and use_postgres: true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix mispelled option for BDD workflows' accurately describes the main change in the pull request, which corrects a misspelled use_posrgres option to use_postgres in the sync configuration.
Description check ✅ Passed The description is directly related to the changeset, mentioning it fixes an issue with creating BDD tests due to a wrong option, which aligns with the configuration fixes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/sync.yml (1)

176-190: Consider adding key validation for extra_options during sync generation.

A small schema/allowlist check in CI for template option names would catch typos like this before they propagate to multiple workflow files.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/sync.yml around lines 176 - 190, Add a validation step that checks
template option keys (e.g., the template map keys and its nested extra_options
entries like use_kafka/use_postgres) against an allowlist/schema during sync
generation; implement this in the sync generator code path that reads the
template objects (the logic that produces the entries shown under template and
extra_options) so it rejects or logs unknown keys and fails CI on mismatches,
returning a clear error mentioning the invalid key names so typos are caught
before workflow files are written.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/sync.yml:
- Around line 176-190: Add a validation step that checks template option keys
(e.g., the template map keys and its nested extra_options entries like
use_kafka/use_postgres) against an allowlist/schema during sync generation;
implement this in the sync generator code path that reads the template objects
(the logic that produces the entries shown under template and extra_options) so
it rejects or logs unknown keys and fails CI on mismatches, returning a clear
error mentioning the invalid key names so typos are caught before workflow files
are written.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 783f3e58-d8f1-4dd3-b0bc-5c3fdf31d188

📥 Commits

Reviewing files that changed from the base of the PR and between c682640 and 87c53cc.

📒 Files selected for processing (1)
  • .github/sync.yml

@joselsegura joselsegura enabled auto-merge May 11, 2026 11:32
@joselsegura joselsegura merged commit d813733 into RedHatInsights:master May 11, 2026
3 checks passed
@joselsegura joselsegura deleted the fix-mispeled-option branch May 11, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants