Fix mispelled option for BDD workflows#162
Conversation
Summary by CodeRabbit
WalkthroughThe sync configuration corrects a misspelled ChangesConfiguration Typo Corrections and DVO Workflow Sync
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/sync.yml (1)
176-190: Consider adding key validation forextra_optionsduring sync generation.A small schema/allowlist check in CI for template option names would catch typos like this before they propagate to multiple workflow files.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/sync.yml around lines 176 - 190, Add a validation step that checks template option keys (e.g., the template map keys and its nested extra_options entries like use_kafka/use_postgres) against an allowlist/schema during sync generation; implement this in the sync generator code path that reads the template objects (the logic that produces the entries shown under template and extra_options) so it rejects or logs unknown keys and fails CI on mismatches, returning a clear error mentioning the invalid key names so typos are caught before workflow files are written.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/sync.yml:
- Around line 176-190: Add a validation step that checks template option keys
(e.g., the template map keys and its nested extra_options entries like
use_kafka/use_postgres) against an allowlist/schema during sync generation;
implement this in the sync generator code path that reads the template objects
(the logic that produces the entries shown under template and extra_options) so
it rejects or logs unknown keys and fails CI on mismatches, returning a clear
error mentioning the invalid key names so typos are caught before workflow files
are written.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 783f3e58-d8f1-4dd3-b0bc-5c3fdf31d188
📒 Files selected for processing (1)
.github/sync.yml
Description
Fix issue when creating several BDD tests with wrong option
Type of change
Testing steps