Skip to content

Fix another mispelled option#163

Merged
joselsegura merged 1 commit into
RedHatInsights:masterfrom
joselsegura:fix-mispeled-option-2
May 11, 2026
Merged

Fix another mispelled option#163
joselsegura merged 1 commit into
RedHatInsights:masterfrom
joselsegura:fix-mispeled-option-2

Conversation

@joselsegura
Copy link
Copy Markdown
Contributor

Description

Second a last fix of mispeleed options:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration update

Testing steps

@joselsegura joselsegura requested a review from a team as a code owner May 11, 2026 11:55
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: f6da1d3c-76e7-4307-8f92-5494da791c36

📥 Commits

Reviewing files that changed from the base of the PR and between d813733 and 7f6704e.

📒 Files selected for processing (1)
  • .github/sync.yml

Summary by CodeRabbit

  • Bug Fixes
    • Corrected parameter naming convention in the BDD workflow configuration to ensure proper workflow generation.

Walkthrough

This PR updates the BDD workflow template configuration in .github/sync.yml for the parquet-factory component, renaming the extra options key from use kafka to use_kafka to match expected parameter naming conventions.

Changes

BDD Workflow Template Configuration

Layer / File(s) Summary
Configuration
.github/sync.yml
The extra_options parameter passed to the parquet-factory component's bdd.yaml.tmpl workflow template is updated: use kafka: trueuse_kafka: true to align with underscore-separated key naming.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title references fixing a misspelled option, which aligns with the changeset that corrects 'use kafka: true' to 'use_kafka: true' in the YAML configuration.
Description check ✅ Passed The description identifies this as a fix for misspelled options in a configuration update, which directly relates to the YAML parameter name correction made in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@joselsegura joselsegura merged commit c5f0f66 into RedHatInsights:master May 11, 2026
3 checks passed
@joselsegura joselsegura deleted the fix-mispeled-option-2 branch May 11, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants