Document and backup rulesets#63
Conversation
ikerreyes
left a comment
There was a problem hiding this comment.
Can you document which is each of the bypass actors?
d8d2de5 to
a9f77c9
Compare
What do you mean? I explained it briefly in the README, what more info is needed about the actors? |
I meant which ID corresponds to which one. If we get an email whatever saying that we need to drop some app and onboard another, it is easier to check which one is each. I guess they are in the same order, in which case it does not matter much. |
a9f77c9 to
1db1ae8
Compare
Summary by CodeRabbit
WalkthroughAdded documentation and configuration files for GitHub branch protection rulesets. A README.md file explains three ruleset JSON configurations that enforce branch protection policies: prodsec_branch_protection.json for production security controls, min_obsint_reviewers.json for minimum review requirements, and status_checks.json for required status check validation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
github-rulesets/README.md (1)
17-17: Optional: Consider simplifying phrasing.The phrase "in order to" can be simplified to "to" for more concise writing.
✍️ Suggested simplification
Line 17:
-It has a bypass for both RedHat Konflux and our own bots in order to allow the auto-merge for +It has a bypass for both RedHat Konflux and our own bots to allow the auto-merge forLine 32:
-It has a bypass for both RedHat Konflux and our own bots in order to allow the auto-merge for +It has a bypass for both RedHat Konflux and our own bots to allow the auto-merge forAlso applies to: 32-32
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@github-rulesets/README.md` at line 17, Replace the verbose phrase "in order to" with the simpler "to" in the README occurrences; specifically update the sentence starting "It has a bypass for both RedHat Konflux and our own bots in order to allow the auto-merge for" and the other line containing "in order to" (line with similar phrasing) so they read "...bots to allow the auto-merge for" and the analogous simplified form.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@github-rulesets/README.md`:
- Line 17: Replace the verbose phrase "in order to" with the simpler "to" in the
README occurrences; specifically update the sentence starting "It has a bypass
for both RedHat Konflux and our own bots in order to allow the auto-merge for"
and the other line containing "in order to" (line with similar phrasing) so they
read "...bots to allow the auto-merge for" and the analogous simplified form.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2d38e6f0-2394-4cde-b210-4c60b7bbcc13
📒 Files selected for processing (4)
github-rulesets/README.mdgithub-rulesets/min_obsint_reviewers.jsongithub-rulesets/prodsec_branch_protection.jsongithub-rulesets/status_checks.json
Description
Add a directory with the export of the existing rule sets in order to serve as reference for other repositories and as documentation for the future.
Type of change
Testing steps
N/A