Add comprehensive ADP (Authorized Data Publishers) support tests#118
Open
jgamblin wants to merge 2 commits intoRedHatProductSecurity:masterfrom
Open
Add comprehensive ADP (Authorized Data Publishers) support tests#118jgamblin wants to merge 2 commits intoRedHatProductSecurity:masterfrom
jgamblin wants to merge 2 commits intoRedHatProductSecurity:masterfrom
Conversation
- Download and integrate CVE Schema 5.2.0 bundled schema file - Extract container-specific schemas for ADP, CNA published, and CNA rejected - Update README compatibility statement to note 5.2.0 support - All existing tests pass with new schema
- Add TestAdpSupport class with 7 comprehensive tests - Create adp-basic-example.json and adp-advanced-example.json test data - Test ADP containers with various content types: - Minimal required fields - With descriptions and metrics - With affected products (SADP pilot use case) - With multiple references - ADP container extraction from full records - Verify schema validation for all ADP container types - All 44 tests pass successfully (37 existing + 7 new)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive test coverage for ADP (Authorized Data Publishers) containers. The ADP publishing functionality was already implemented in cvelib, but this PR ensures it works correctly for various ADP use cases including the SADP pilot and other ADP analyses.
Changes
Test Data Files
Test Coverage
Added
TestAdpSupportclass with 7 comprehensive tests:Key Features Tested
✅ Basic ADP container validation
✅ Advanced ADP with descriptions and references
✅ ADP with affected product information
✅ ADP container extraction from full CVE records
✅ Schema compliance for various ADP content types
✅ SADP pilot use cases (affected products, descriptions)
✅ Multiple reference support
Testing
Implementation Notes
The ADP publishing feature was already implemented in cvelib with:
CveApi.publish_adp()method for publishing ADP containerscli.publish-adpcommand for CLI accessThis PR enhances the test coverage to ensure the implementation works correctly for various ADP use cases, particularly for:
Resolves
Closes #114 - New feature: ADP support