Implement rangeQuery for VecSimTieredIndex - [MOD-5164]
#360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
guyav-tiered_hnsw_batch_iterator
to
feature_HNSW_tiered_index
April 24, 2023 15:17
GuyAv46
force-pushed
the
guyav-tiered_hnsw_range
branch
from
914214a to
1122fa4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature_HNSW_tiered_index #360 +/- ##
============================================================
Coverage ? 96.78%
============================================================
Files ? 66
Lines ? 4600
Branches ? 0
============================================================
Hits ? 4452
Misses ? 148
Partials ? 0 ☔ View full report in Codecov by Sentry. |
GuyAv46
force-pushed
the
guyav-tiered_hnsw_range
branch
from
37fdb48 to
e9d9e91
Compare
alonre24
reviewed
Apr 30, 2023
Collaborator
alonre24
left a comment
alonre24
left a comment
There was a problem hiding this comment.
No actual comments, just add clarifications in tests
alonre24
approved these changes
May 1, 2023
GuyAv46
force-pushed
the
guyav-tiered_hnsw_range
branch
from
17481cf to
6f9c772
Compare
DvirDukhan
reviewed
May 1, 2023
DvirDukhan
approved these changes
May 7, 2023
... including needed utility functions
the old entry point but then we get the new max level when trying to search using the old one
Co-authored-by: alonre24 <alonreshef24@gmail.com>
Co-authored-by: alonre24 <alonreshef24@gmail.com>
GuyAv46
force-pushed
the
guyav-tiered_hnsw_range
branch
from
6f9c772 to
0fd8225
Compare
meiravgri
pushed a commit
that referenced
this pull request
May 8, 2023
* implemented `rangeQuery` for VecSimTieredIndex, ... including needed utility functions * renaming `merge_results.h` and moving `filter_results` to it * fix build * first test and some fixes * improved test and added a parallel test * fix a bug where we safely get (from `safeGetEntryPoint`) the old entry point but then we get the new max level when trying to search using the old one * fix tests * Update comments * review fixes * after rebase fixes * added a general comment on tiered index's guarantees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Implements
rangeQueryfor VecSimTieredIndex.As part of this, the sorting (order) of the returned results moved from the C API to the C++ API and added an overload function for the range query call.
This PR also includes a fix for
searchBottomLayerEP, where we (safely) get a copy of the old entry point, but by the time we get to get themax_level_it was updated to the new max level of the new entry point, and we tried to look at a non-existing neighbor list of the old entry point at the new max level.Main objects this PR modified
VecSimTieredIndexsearchBottomLayerEPMark if applicable