shrink to fit in BF index [CP] #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvirDukhan
approved these changes
May 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 0.6 #365 +/- ##
=======================================
Coverage 95.01% 95.02%
=======================================
Files 60 60
Lines 3412 3414 +2
=======================================
+ Hits 3242 3244 +2
Misses 170 170
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Cherry-pick from #362
id_to_label_mapping in brute force index is a std::vector, and whenever we resize it, its capacity is determined according to this container's policy. Then, when we add a block and call for resize, the capacity is doubled (rather than increased by block size). The fix is calling shring_to_fit() which deallocates unnecessary memory from the container (so its capacity matches its size).