idToLabel in flat index - shrink to fit and avoid invalid access MOD-5212 #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s requires changing a bit the logic of updating jobs id after removing a vector from flat buffer and swap ids.
…_last_id_insert_job
alonre24
changed the title
DvirDukhan
approved these changes
May 7, 2023
meiravgri
pushed a commit
that referenced
this pull request
May 8, 2023
…s requires changing a bit the logic of updating jobs id after removing a vector from flat buffer and swap ids. (#367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Let the capacity of
idToLabelin flat index be tight to the size (practically cherry-pick from #362).This also requires changing a bit of the logic of updating pending insert job ids after removing a vector from the flat buffer. Until now, we accessed the (previous) last id in
idToLabelAFTER the removal and swap. However, at that time this position is no longer valid (since we decreased theidToLabelsize during the deletion), and now it can even cause a segmentation fault since we deallocate the last block upon deleting the last vector of the block.The fix includes accessing the last id in
idToLabelto get the relevant label BEFORE the deletion.Mark if applicable