Bugfixes in windows phone user control and samples#102
Closed
jjchiw wants to merge 2 commits intoRedth:masterfrom
Closed
Bugfixes in windows phone user control and samples#102jjchiw wants to merge 2 commits intoRedth:masterfrom
jjchiw wants to merge 2 commits intoRedth:masterfrom
Conversation
In the sample project when you try to enter for second time in the
custom layout there was an exception, because the custom layer is never
detached from the previous ScanPage.xaml
this was the exception
'gridCustomOverlay.Children.Add(CustomOverlay)' threw an exception of
type 'System.InvalidOperationException'
base: {System.InvalidOperationException: Element is already the child of
another element.
at MS.Internal.XcpImports.CheckHResult(UInt32 hr)
at
MS.Internal.XcpImports.Collection_AddValue[T](PresentationFrameworkCollection`1
collection, CValue value)
at
MS.Internal.XcpImports.Collection_AddDependencyObject[T](PresentationFrameworkCollection`1
collection, DependencyObject value)
at
System.Windows.PresentationFrameworkCollection`1.AddDependencyObject(DependencyObject
value)
at System.Windows.Controls.UIElementCollection.AddInternal(UIElement
value)
at System.Windows.PresentationFrameworkCollection`1.Add(T value)}
The action to the buttons (cancel and torch) of the custom layer were
only added once, because the buttons where already wired with an action.
All the events in ScanPage are set to null when it's navigated from the
page, because the Events are static and we were adding action everytime
we navigated to the page
Owner
|
Thanks I'll take a look at this soon! |
Redth
added a commit
that referenced
this pull request
Apr 14, 2014
Owner
|
I've manually merged these suggestions, thanks again :) |
Author
|
Great!........I'm glad to contribute. Cheers! On Mon, Apr 14, 2014 at 4:28 PM, Jon Dick notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the sample project when you try to enter for second time in the custom layout there was an exception, because the custom layer is never detached from the previous ScanPage.xaml
this was the exception
In the sample.
The action to the buttons (cancel and torch) of the custom layer were only added once, because the buttons where already wired with an action.
All the events in ScanPage are set to null when it's navigated from the
page, because the Events are static and we were adding action everytime
we navigated to the page