Skip to content

BUGFIX - Forms Android SurfaceView when IsScanning is set to False th… #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomasz23 wants to merge 1 commit into from
Closed

BUGFIX - Forms Android SurfaceView when IsScanning is set to False th… #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion Samples/Forms/Core/CustomScanPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public CustomScanPage () : base ()
await DisplayAlert ("Scanned Barcode", result.Text, "OK");

// Navigate away
await Navigation.PopAsync ();
//await Navigation.PopAsync ();
});

overlay = new ZXingDefaultOverlay
Expand All @@ -49,8 +49,42 @@ public CustomScanPage () : base ()
VerticalOptions = LayoutOptions.FillAndExpand,
HorizontalOptions = LayoutOptions.FillAndExpand,
};

var stopButton = new Button
{
WidthRequest = 100,
HeightRequest = 50,
HorizontalOptions = LayoutOptions.Start,
VerticalOptions = LayoutOptions.End,
Text = "disable",
Command = new Command(() => zxing.IsScanning=false)
};

var cancelButton = new Button
{
WidthRequest = 100,
HeightRequest = 50,
HorizontalOptions = LayoutOptions.Center,
VerticalOptions = LayoutOptions.End,
Text = "cancel",
Command = new Command(async () => await Navigation.PopAsync())
};

var startButton = new Button
{
WidthRequest = 100,
HeightRequest = 50,
HorizontalOptions = LayoutOptions.End,
VerticalOptions = LayoutOptions.End,
Text = "enable",
Command = new Command(() => zxing.IsScanning = true)
};

grid.Children.Add(zxing);
grid.Children.Add(overlay);
grid.Children.Add(startButton);
grid.Children.Add(cancelButton);
grid.Children.Add(stopButton);

// The root page of your application
Content = grid;
Expand Down
1 change: 1 addition & 0 deletions Source/ZXing.Net.Mobile.Android/ZXingSurfaceView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public void AutoFocus(int x, int y)

public void StartScanning(Action<Result> scanResultCallback, MobileBarcodeScanningOptions options = null)
{
_cameraAnalyzer.SetupCamera();
ScanningOptions = options ?? MobileBarcodeScanningOptions.Default;

_cameraAnalyzer.BarcodeFound += (sender, result) =>
Expand Down