Deduplicate subscriptions in GET /subscription#278
Merged
Timothy-Gonzalez merged 3 commits intomainfrom Sep 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the GET /subscription endpoint to deduplicate subscriptions by mailing list, aggregating user IDs for each unique mailing list instead of returning individual subscription records.
- Implemented aggregation logic to group subscriptions by mailing list with arrays of user IDs
- Updated the response format from individual subscription objects to aggregated objects with
mailingListanduserIdsproperties - Added comprehensive test coverage for the new aggregation behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/services/subscription/subscription-router.ts | Added reduce operation to aggregate subscriptions by mailing list |
| src/services/subscription/subscription-router.test.ts | Updated existing test and added new test for multiple mailing lists aggregation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This reverts commit 4cc5a98.
Timothy-Gonzalez
requested changes
Sep 18, 2025
Timothy-Gonzalez
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.