feat(incremental): Make from and to in incremental scan optional#9
Merged
feat(incremental): Make from and to in incremental scan optional#9
Conversation
vustef
approved these changes
Nov 14, 2025
Collaborator
vustef
left a comment
vustef
left a comment
There was a problem hiding this comment.
Thanks Gerald, just one comment. Also since it's an API change, we have to update iceberg_rust_ffi and RustyIceberg.jl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes RAI-44111
What changes are included in this PR?
Makes the
fromandtosnapshot arguments in incremental scanning optional. Whenfromis omitted, we scan from the root snapshot, while whentois omitted, we scan to the latest snapshot.Are these changes tested?
I modified the existing incremental tests to omit
fromandtowhenever appropriate.