Skip to content

ENH: enable Travis to run shellcheck#12

Merged
yarikoptic merged 3 commits intoReproNim:masterfrom
yarikoptic:enh-travis+shellcheck
Jun 24, 2019
Merged

ENH: enable Travis to run shellcheck#12
yarikoptic merged 3 commits intoReproNim:masterfrom
yarikoptic:enh-travis+shellcheck

Conversation

@yarikoptic
Copy link
Member

#11 could either adopt it (if we merge it in) to run shellcheck on all script/* files (all bash ATM) or we could do that later.


function error() {
echo -e "E: $@" >&2
echo -e "E:" "$@" >&2
Copy link
Member Author

@yarikoptic yarikoptic Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not 100% certain that separating this way wouldn't cause some values to be interpreted as options to echo, but seems to be not:

$> cat /tmp/checkecho
#!/bin/bash
echo -e "I1: $@"
echo -e "I2:" "$@"

$> /tmp/checkecho '-n' 1 "2 3" '&' '${var}'
I1: -n 1 2 3 & ${var}
I2: -n 1 2 3 & ${var}

so all good

@yarikoptic
Copy link
Member Author

ok, all green! from now on could only get even greener ;-)

@yarikoptic yarikoptic merged commit 034367f into ReproNim:master Jun 24, 2019
@yarikoptic yarikoptic deleted the enh-travis+shellcheck branch February 17, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant